cyb70289 commented on pull request #9274: URL: https://github.com/apache/arrow/pull/9274#issuecomment-764217852
> @cyb70289 `arrow::dataset::Expression::Call::options` requires that virtual destructor since a `shared_ptr<FunctionOptions>` is used to store subclasses of FunctionOptions. Removing this virtual destructor results in a resource leak since the derived classes' (implicit) destructors are not being called, leaking data members such as `arrow::compute::SetLookupOptions::value_set` which are not destroyed. Thanks @bkietz , I missed this point. Will update according to your comment. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
