davisusanibar commented on code in PR #37723:
URL: https://github.com/apache/arrow/pull/37723#discussion_r1434187598
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/StackTrace.java:
##########
@@ -19,12 +19,15 @@
import java.util.Arrays;
+import org.checkerframework.checker.nullness.qual.Nullable;
+
+
/**
* Convenient way of obtaining and manipulating stack traces for debugging.
*/
public class StackTrace {
- private final StackTraceElement[] stackTraceElements;
+ private final @Nullable StackTraceElement [] stackTraceElements;
Review Comment:
This is the error without any annotation: found = what 3rd party library are
offering in theirs API, required = what our apache arrow java library are
offering
```
[ERROR] found : @Initialized @Nullable StackTraceElement @Initialized
@NonNull []
[ERROR] required: @Initialized @NonNull StackTraceElement @Initialized
@NonNull []
```
Without any annotation, the framework assume that this variable is @ NonNull
, in this case the Checker framework scanning `found` that `stackTraceElements
` will be nullable, for that reason I added @ Nullable annotations instead of @
NonNull default annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
