paleolimbot commented on code in PR #341:
URL: https://github.com/apache/arrow-nanoarrow/pull/341#discussion_r1434191318
##########
dev/release/verify-release-candidate.sh:
##########
@@ -217,6 +217,7 @@ test_cmake_project() {
show_info "Configure CMake Project"
${CMAKE_BIN} "${NANOARROW_SOURCE_DIR}/${2}" \
"${@:3}" \
+ -DCMAKE_POSITION_INDEPENDENT_CODE=ON \
Review Comment:
I looked into this a little more deeply (specifically, trying
`set_target_properties(nanoarrow_c_data_integration PROPERTIES
POSITION_INDEPENDENT_CODE ON)` and the version of that you suggested as well.
It seems like the solution would require the `nanoarrow` target to be
position-independent, which is a bad default for actual use of nanoarrow (but a
totally fine default for testing). Another option would be to `if
(NANOARROW_BUILD_TESTS) set(CMAKE_POSITION_INDEPENDENT_CODE ON)` but the
command-line version seems less intrusive?
FWIW I was experimenting with:
```
# docker run --platform=linux/amd64 --rm -it -v $(pwd):/nanoarrow
ghcr.io/apache/arrow-nanoarrow:centos7
mkdir /nanoarrow/build && cd /nanoarrow/build
cmake3 .. -DNANOARROW_BUILD_TESTS=ON
cmake3 --build .
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
