kou commented on code in PR #39321:
URL: https://github.com/apache/arrow/pull/39321#discussion_r1434615079
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -119,6 +119,14 @@ Status AzureOptions::ConfigureDefaultCredential(const
std::string& account_name)
return Status::OK();
}
+Status AzureOptions::ConfigureManagedIdentityCredential(const std::string&
account_name,
+ std::string const&
clientId) {
Review Comment:
Could you use `const XXX` style?
Could you use `snake_case`?
```suggestion
const std::string&
client_id) {
```
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -119,6 +119,14 @@ Status AzureOptions::ConfigureDefaultCredential(const
std::string& account_name)
return Status::OK();
}
+Status AzureOptions::ConfigureManagedIdentityCredential(const std::string&
account_name,
Review Comment:
It seems that `account_name` isn't used. Is it needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
