paleolimbot commented on PR #39250: URL: https://github.com/apache/arrow/pull/39250#issuecomment-1867175401
Thank you @felipecrv and @danepitkin for the feedback (and sorry to everybody for taking a few days to circle back here...I wanted to make sure I addressed the comments properly!). I added a `ARROW_R_DCHECK()` guarded by a special `ARROW_R_DEBUG`...we don't have any precedent in the package so far for using the existing DCHECK macros and I'm a little worried it will add `cerr` or `abort` symbols. I'm probably the only person that will have it enabled but at least it gives us a place to put some of these checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
