niyue commented on code in PR #39098:
URL: https://github.com/apache/arrow/pull/39098#discussion_r1434712030
##########
cpp/src/gandiva/llvm_generator.h:
##########
@@ -47,15 +49,17 @@ class FunctionHolder;
class GANDIVA_EXPORT LLVMGenerator {
public:
/// \brief Factory method to initialize the generator.
- static Status Make(const std::shared_ptr<Configuration>& config, bool cached,
- std::unique_ptr<LLVMGenerator>* llvm_generator);
+ static Result<std::unique_ptr<LLVMGenerator>> Make(
Review Comment:
Explained above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
