js8544 commented on code in PR #39245:
URL: https://github.com/apache/arrow/pull/39245#discussion_r1434783979
##########
cpp/src/arrow/compute/kernels/scalar_string_ascii.cc:
##########
@@ -95,7 +95,7 @@ struct FixedSizeBinaryTransformExecBase {
ctx->Allocate(output_width * input_nstrings));
uint8_t* output_str = values_buffer->mutable_data();
- const uint8_t* input_data = input.GetValues<uint8_t>(1);
+ const uint8_t* input_data = input.GetValues<uint8_t>(1, input.offset *
input_width);
Review Comment:
The current `FixedSizeBinaryTransformExecBase` deals with offsets wrongly. I
fixed the bug and added a test for `binary_replace_slice` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
