viirya commented on code in PR #8631:
URL: https://github.com/apache/arrow-datafusion/pull/8631#discussion_r1435363992
##########
datafusion/physical-expr/src/regex_expressions.rs:
##########
@@ -58,7 +59,7 @@ pub fn regexp_match<T: OffsetSizeTrait>(args: &[ArrayRef]) ->
Result<ArrayRef> {
2 => {
let values = as_generic_string_array::<T>(&args[0])?;
let regex = as_generic_string_array::<T>(&args[1])?;
- compute::regexp_match(values, regex, None).map_err(|e|
arrow_datafusion_err!(e))
+ _regexp_match(values, regex, None).map_err(|e|
arrow_datafusion_err!(e))
Review Comment:
Yea, for the ScalarUDF in DataFusion, we probably can rely on further
optimization like #8051. Per kernel perspective, I will probably submit a Datum
version later as mentioned
https://github.com/apache/arrow-rs/pull/5235#issuecomment-1868071898.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
