mason142 commented on PR #39264:
URL: https://github.com/apache/arrow/pull/39264#issuecomment-1868140023
> Thanks for submitting this PR @mason142 . Here are a couple comments, I'm
not sure the solution is right here.
Hi @pitrou, thank you very much for looking at my PR and giving your
thoughts. I rewrote my solution to better follow the semantics of .replace() in
python. I was a little unsure on how to handle the case of "".replace("",
any_string) so I hardcoded that edge case at the beginning of ReplaceSubstring.
Any other advice would be greatly appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
