comphead commented on code in PR #8622:
URL: https://github.com/apache/arrow-datafusion/pull/8622#discussion_r1435421181
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -883,6 +899,10 @@ pub fn array_append(args: &[ArrayRef]) -> Result<ArrayRef>
{
/// Array_sort SQL function
pub fn array_sort(args: &[ArrayRef]) -> Result<ArrayRef> {
+ if args.is_empty() || args.len() > 3 {
Review Comment:
Checking input arguments validity in public methods is good practice imho.
But the comment above was mostly to thinking on having a generic approach to
return a friendly message to the user about what is wrong and what is the next
step. Now we usually saying the input arguments has to be 1, 2, 3 arguments but
it is mostly meaningless, we can probably improve it with more detailed message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
