alamb commented on code in PR #8627:
URL: https://github.com/apache/arrow-datafusion/pull/8627#discussion_r1435575200
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -1206,13 +1206,28 @@ message PartitionColumn {
message FileTypeWriterOptions {
oneof FileType {
JsonWriterOptions json_options = 1;
+ ParquetWriterOptions parquet_options = 2;
}
}
message JsonWriterOptions {
CompressionTypeVariant compression = 1;
}
+message ParquetWriterOptions {
+ WriterProperties writer_properties = 1;
+}
+
+message WriterProperties {
+ int32 data_page_size_limit = 1;
Review Comment:
given the rust fields are usize, is there any reason to use in32 in the
protobuf encoding?
Maybe it would make more sense to use `i64` or `u64` here instead 🤔
https://protobuf.dev/programming-guides/proto2/#scalar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
