marvinlanhenke commented on issue #8502: URL: https://github.com/apache/arrow-datafusion/issues/8502#issuecomment-1868742869
@alamb thanks for the pointers. I already implemented a working solution, however I need to do some refactoring (if my kids lets me :P ). I'd also like to extract the common functionality since NdJson and CSV implementation is nearly the same; any suggestions where to put those `utility` functions, like `find_first_newline`? I think mod.rs would be fine? Alternatively it could be a default impl on the `FileOpener` - however with this approach I don't like the mix of responsibilities - though I'd prefer mod.rs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
