alamb commented on code in PR #8630:
URL: https://github.com/apache/arrow-datafusion/pull/8630#discussion_r1435237999
##########
datafusion/core/src/dataframe/mod.rs:
##########
@@ -1640,57 +1644,31 @@ mod tests {
let config = SessionConfig::new().with_target_partitions(1);
let ctx = SessionContext::new_with_config(config);
- let table1 = table_with_constraints();
- let df = ctx.read_table(table1)?;
- let col_id = Expr::Column(datafusion_common::Column {
- relation: None,
- name: "id".to_string(),
- });
- let col_name = Expr::Column(datafusion_common::Column {
- relation: None,
- name: "name".to_string(),
- });
+ let df = ctx.read_table(table_with_constraints())?;
- // group by contains id column
- let group_expr = vec![col_id.clone()];
+ // GROUP BY id
+ let group_expr = vec![col("id")];
let aggr_expr = vec![];
let df = df.aggregate(group_expr, aggr_expr)?;
- let condition1 = Expr::BinaryExpr(BinaryExpr::new(
- Box::new(col_id.clone()),
- Operator::Eq,
- Box::new(Expr::Literal(ScalarValue::Int32(Some(1)))),
- ));
- let condition2 = Expr::BinaryExpr(BinaryExpr::new(
- Box::new(col_name),
- Operator::Eq,
- Box::new(Expr::Literal(ScalarValue::Utf8(Some("a".to_string())))),
- ));
- // Predicate refers to id, and name fields
- let predicate = Expr::BinaryExpr(BinaryExpr::new(
- Box::new(condition1),
- Operator::And,
- Box::new(condition2),
- ));
+ // Predicate refers to id, and name fields:
+ // id = 1 AND name = 'a'
+ let predicate = col("id").eq(lit(1i32)).and(col("name").eq(lit("a")));
Review Comment:
I think the expr API is more concise and makes it easer to quickly
understand what expression is being created
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
