tustvold commented on code in PR #5247: URL: https://github.com/apache/arrow-rs/pull/5247#discussion_r1436638219
########## object_store/src/aws/dynamo.rs: ########## @@ -61,16 +63,24 @@ const STORE: &str = "DynamoDB"; /// /// The DynamoDB schema is as follows: /// -/// * A string hash key named `"key"` +/// * A string partition key named `"path"` +/// * A string sort key named `"etag"` Review Comment: This is a breaking change, but given #4918 was only merged this morning and hasn't been released I think that is fine. Before I had planned to encode both the path and the etag in the partition key, as was documented here, but this requires a delimiter, which after #5020 can't be `#`. This new approach avoids this, whilst also being I think easier to understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
