korowa commented on PR #8462: URL: https://github.com/apache/arrow-datafusion/pull/8462#issuecomment-1870111607
Thank you @Weijun-H! This PR, though, looks like the implementation of `CountDistinct` accumulator, and it doesn't seem that any approximation is performed in the code -- won't it be better to use these changes as default `CountDistinct` implementation for specified data types? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
