peter-toth commented on PR #7942: URL: https://github.com/apache/arrow-datafusion/pull/7942#issuecomment-1870398974
Thanks you all for the feedbacks! I've updated the PR description with the lastest findings. - With 1. and 2. let's wait for the new benchmarks https://github.com/apache/arrow-datafusion/issues/8638 and the `TreeNode` cleanup PR: https://github.com/apache/arrow-datafusion/pull/8653. - I discarded 3. as adding `Expr::Nop` isn't needed. We can use use `Expr::Literal(ScalarValue::Null)` where a dummy `Expr` is required: https://github.com/apache/arrow-datafusion/pull/7942#discussion_r1432926780 - I extracted 4. into an issue: https://github.com/apache/arrow-datafusion/issues/8663 and opened a PR for it: https://github.com/apache/arrow-datafusion/pull/8664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
