andygrove commented on code in PR #8665:
URL: https://github.com/apache/arrow-datafusion/pull/8665#discussion_r1437180258
##########
datafusion/core/benches/sql_planner.rs:
##########
@@ -60,6 +60,44 @@ pub fn create_table_provider(column_prefix: &str,
num_columns: usize) -> Arc<Mem
MemTable::try_new(schema, vec![]).map(Arc::new).unwrap()
}
+pub fn create_tpch_schemas() -> [(String, Schema); 2] {
+ let lineitem_schema = Schema::new(vec![
+ Field::new("l_orderkey", DataType::Int32, false),
+ Field::new("l_partkey", DataType::Int32, false),
+ Field::new("l_suppkey", DataType::Int32, false),
+ Field::new("l_linenumber", DataType::Int32, false),
+ Field::new("l_quantity", DataType::Float64, false),
+ Field::new("l_extendedprice", DataType::Float64, false),
+ Field::new("l_discount", DataType::Float64, false),
+ Field::new("l_tax", DataType::Float64, false),
Review Comment:
It may not be important for this benchmark, but financial amounts should be
decimal rather than float. We have these schema definitions already in
https://github.com/apache/arrow-datafusion/blob/main/benchmarks/src/tpch/mod.rs#L45
that should match the TPC-H specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
