Weijun-H commented on code in PR #8679:
URL: https://github.com/apache/arrow-datafusion/pull/8679#discussion_r1438259321
##########
datafusion/sqllogictest/test_files/array.slt:
##########
@@ -107,6 +107,18 @@ AS VALUES
(make_array(make_array(4, 5, 6), make_array(10, 11, 12), make_array(4, 9,
8), make_array(7, 8, 9), make_array(10, 11, 12), make_array(1, 8, 7)),
make_array(10, 11, 12), 3, make_array([[11, 12, 13], [14, 15, 16]], [[17, 18,
19], [20, 21, 22]]), make_array(121, 131, 141))
;
+# statement ok
+# CREATE TABLE large_nested_arrays
+# AS
+# SELECT
+# arrow_cast(column1, 'LargeList(LargeList(Int64))') AS column1,
+# arrow_cast(column2, 'LargeList(Int64)') AS column2,
+# column3,
+# arrow_cast(column4, 'LargeList(LargeList(List(Int64)))') AS column4,
+# arrow_cast(column5, 'LargeList(Int64)') AS column5
+# FROM nested_arrays
+# ;
+
Review Comment:
cast `List(List)` to `LargeList(LargeList)` are not supported yet.
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -52,22 +52,6 @@ macro_rules! downcast_arg {
}};
}
-/// Downcasts multiple arguments into a single concrete type
-/// $ARGS: &[ArrayRef]
-/// $ARRAY_TYPE: type to downcast to
-///
-/// $returns a Vec<$ARRAY_TYPE>
-macro_rules! downcast_vec {
- ($ARGS:expr, $ARRAY_TYPE:ident) => {{
- $ARGS
- .iter()
- .map(|e| match e.as_any().downcast_ref::<$ARRAY_TYPE>() {
- Some(array) => Ok(array),
- _ => internal_err!("failed to downcast"),
- })
- }};
-}
-
Review Comment:
Unused function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
