comphead commented on code in PR #8678:
URL: https://github.com/apache/arrow-datafusion/pull/8678#discussion_r1438368463
##########
datafusion/physical-expr/src/aggregate/first_last.rs:
##########
@@ -87,6 +90,33 @@ impl FirstValue {
pub fn ordering_req(&self) -> &LexOrdering {
&self.ordering_req
}
+
+ pub fn with_requirement_satisfied(mut self, requirement_satisfied: bool)
-> Self {
+ self.requirement_satisfied = requirement_satisfied;
+ self
+ }
+
+ pub fn convert_to_last(self) -> LastValue {
+ let name = if self.name.starts_with("FIRST") {
Review Comment:
case sensitive, or it comes upper case always?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
