viirya commented on code in PR #5256:
URL: https://github.com/apache/arrow-rs/pull/5256#discussion_r1438393142
##########
arrow/src/ffi_stream.rs:
##########
@@ -358,9 +358,8 @@ impl Iterator for ArrowArrayStreamReader {
}
let data = unsafe {
- from_ffi_and_data_type(array,
DataType::Struct(self.schema().fields().clone()))
- }
- .ok()?;
+ from_ffi_and_data_type(array,
DataType::Struct(self.schema().fields().clone()))?
+ };
Review Comment:
```
error[E0277]: the `?` operator can only be used on `Option`s, not `Result`s,
in a method that returns `Option`
```
Oh right, I think one reason to suppress error is because that too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
