peter-toth commented on code in PR #8672:
URL: https://github.com/apache/arrow-datafusion/pull/8672#discussion_r1438510839
##########
datafusion/common/src/tree_node.rs:
##########
@@ -342,18 +355,21 @@ pub trait DynTreeNode {
/// Blanket implementation for Arc for any tye that implements
/// [`DynTreeNode`] (such as [`Arc<dyn PhysicalExpr>`])
impl<T: DynTreeNode + ?Sized> TreeNode for Arc<T> {
+ fn children_nodes(&self) -> Vec<Arc<T>> {
+ self.arc_children()
+ }
+
fn apply_children<F>(&self, op: &mut F) -> Result<VisitRecursion>
where
F: FnMut(&Self) -> Result<VisitRecursion>,
{
- for child in self.arc_children() {
- match op(&child)? {
+ for child in &self.arc_children() {
Review Comment:
Do we need this 2nd `apply_children()` implementation here? The base
implementation in `TreeNode` might be enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
