tyrelr commented on pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#issuecomment-766105862
current 10% perf impact looks like:
```
critcmp master-499b6d0c array-slice-41c29bc4 -t 10
group array-slice-41c29bc4
master-499b6d0c
----- --------------------
---------------
add_nulls_512 1.00 349.6±1.41ns ? B/sec 1.30
452.9±1.68ns ? B/sec
array_from_vec 128 1.17 466.8±0.76ns ? B/sec 1.00
399.4±1.21ns ? B/sec
bench_primitive 1.38 3.1±0.01ms 1277.6 MB/sec 1.00
2.3±0.02ms 1766.1 MB/sec
concat i32 1024 1.21 3.0±0.00µs ? B/sec 1.00
2.5±0.01µs ? B/sec
equal_string_512 1.00 111.7±0.34ns ? B/sec 1.17
131.2±0.77ns ? B/sec
from_slice 1.64 835.2±1.80µs ? B/sec 1.00
510.7±0.77µs ? B/sec
like_utf8 scalar ends with 1.11 366.5±1.52µs ? B/sec 1.00
331.3±0.62µs ? B/sec
like_utf8 scalar equals 1.20 105.6±0.19µs ? B/sec 1.00
88.2±0.17µs ? B/sec
nlike_utf8 scalar starts with 1.13 455.3±2.89µs ? B/sec 1.00
403.1±3.25µs ? B/sec
subtract 512 1.20 453.0±0.88ns ? B/sec 1.00
376.1±6.67ns ? B/sec
take i32 nulls 512 1.13 1120.3±3.11ns ? B/sec 1.00
993.1±1.18ns ? B/sec
```
from_slice should just be noise (no changes to buffer)
the operations on primitives should just be noise (no changes to primitive
array)
But the 'string' functions in particular stand out to me...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]