viirya commented on code in PR #8707:
URL: https://github.com/apache/arrow-datafusion/pull/8707#discussion_r1439070444
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -591,10 +559,6 @@ impl LogicalPlan {
/// // create new plan using rewritten_exprs in same position
/// let new_plan = plan.new_with_exprs(rewritten_exprs, new_inputs);
/// ```
- ///
- /// Note: sometimes [`Self::with_new_exprs`] will use schema of
- /// original plan, it will not change the scheam. Such as
- /// `Projection/Aggregate/Window`
Review Comment:
This comment looks incorrect. For `Projection/Aggregate/Window`, the schema
might change if input/expressions are changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
