tustvold commented on code in PR #5268:
URL: https://github.com/apache/arrow-rs/pull/5268#discussion_r1439096303
##########
object_store/src/aws/credential.rs:
##########
@@ -24,16 +24,40 @@ use crate::{CredentialProvider, Result, RetryConfig};
use async_trait::async_trait;
use bytes::Buf;
use chrono::{DateTime, Utc};
+use hyper::header::HeaderName;
use percent_encoding::utf8_percent_encode;
use reqwest::header::{HeaderMap, HeaderValue};
use reqwest::{Client, Method, Request, RequestBuilder, StatusCode};
use serde::Deserialize;
+use snafu::{ResultExt, Snafu};
use std::collections::BTreeMap;
use std::sync::Arc;
use std::time::{Duration, Instant};
use tracing::warn;
use url::Url;
+#[derive(Debug, Snafu)]
+#[allow(clippy::enum_variant_names)]
Review Comment:
Otherwise clippy complains about the same prefix for the variants, this is
future proofing for when we add further variants for the other error
propagation in this module that is currently very ad-hoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
