vibhatha commented on code in PR #37723:
URL: https://github.com/apache/arrow/pull/37723#discussion_r1439109377
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/HistoricalLog.java:
##########
@@ -122,13 +124,16 @@ public synchronized void buildHistory(
.append('\n');
if (firstEvent != null) {
+ long time = firstEvent.time;
+ String note = firstEvent.note;
+ final StackTrace stackTrace = firstEvent.stackTrace;
sb.append(innerIndentation)
- .append(firstEvent.time)
+ .append(time)
.append(' ')
- .append(firstEvent.note)
+ .append(note)
.append('\n');
if (includeStackTrace) {
- firstEvent.stackTrace.writeToBuilder(sb, indent + 2);
+ stackTrace.writeToBuilder(sb, indent + 2);
Review Comment:
nit: why introducing new variables?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
