clbarnes commented on code in PR #5222:
URL: https://github.com/apache/arrow-rs/pull/5222#discussion_r1439557074
##########
object_store/src/local.rs:
##########
@@ -416,9 +419,16 @@ impl ObjectStore for LocalFileSystem {
let meta = convert_metadata(metadata, location)?;
options.check_preconditions(&meta)?;
+ let range = if let Some(r) = options.range {
+ r.as_range(meta.size)
+ .map_err(|e| as_generic_err(STORE, e))?
Review Comment:
Does adding a new variant in this way mean that every downstream user needs
to handle their error differently (e.g. when matching error types) even when
they're not doing something range-related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
