Tom-Newton commented on code in PR #39361:
URL: https://github.com/apache/arrow/pull/39361#discussion_r1439923318
##########
cpp/src/arrow/filesystem/azurefs.cc:
##########
@@ -1645,21 +1748,93 @@ Result<FileInfoVector>
AzureFileSystem::GetFileInfo(const FileSelector& select)
Status AzureFileSystem::CreateDir(const std::string& path, bool recursive) {
ARROW_ASSIGN_OR_RAISE(auto location, AzureLocation::FromString(path));
- if (recursive) {
- return impl_->CreateDirRecursive(location);
- } else {
- return impl_->CreateDir(location);
+ if (location.container.empty()) {
+ return Status::Invalid("CreateDir requires a non-empty path.");
Review Comment:
Should this be container not path?
```suggestion
return Status::Invalid("CreateDir requires a non-empty container.");
```
If yes there are some more where we should apply the same change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
