viirya commented on code in PR #8731:
URL: https://github.com/apache/arrow-datafusion/pull/8731#discussion_r1440196264
##########
datafusion/core/src/physical_optimizer/enforce_distribution.rs:
##########
@@ -1362,17 +1351,10 @@ impl DistributionContext {
fn update_children(mut self) -> Result<Self> {
for child_context in self.children_nodes.iter_mut() {
- child_context.distribution_connection = match
child_context.plan.as_any() {
- plan_any if plan_any.is::<RepartitionExec>() => matches!(
- plan_any
- .downcast_ref::<RepartitionExec>()
- .unwrap()
- .partitioning(),
- Partitioning::RoundRobinBatch(_) | Partitioning::Hash(_, _)
- ),
Review Comment:
Unnecessary matching. For all supported partitioning in `RepartitionExec`,
`distribution_connection` should be true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
