tushushu commented on issue #8680: URL: https://github.com/apache/arrow-datafusion/issues/8680#issuecomment-1875281605
> > The `CreateExternalTableNode` appears 15 times while the `JsonWriterOptions` appears 34 times.. I would arbitrarily assume that using the latter would result in smaller changes and impact. > > https://github.com/search?q=repo%3Aapache%2Farrow-datafusion%20CreateExternalTableNode&type=code shows only 3 matches 🤔 > > there are a few files that are generated (e.g. pbjson or protobuf) which perhaps is what you are finding but would not show up in your seach The link above shows 3 file matches. If I add a file filter in my VSCode where filetype = `*.rs`, `CreateExternalTableNode` shows 13 results in 3 files. `JsonWriterOptions` shows 32 results in 8 files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
