jayzhan211 commented on code in PR #8729:
URL: https://github.com/apache/arrow-datafusion/pull/8729#discussion_r1440438702
##########
datafusion/physical-expr/src/array_expressions.rs:
##########
@@ -2054,9 +2067,34 @@ pub fn array_to_string(args: &[ArrayRef]) ->
Result<ArrayRef> {
let mut arg = String::from("");
let mut res: Vec<Option<String>> = Vec::new();
- match arr.data_type() {
- DataType::List(_) | DataType::LargeList(_) |
DataType::FixedSizeList(_, _) => {
- let list_array = arr.as_list::<i32>();
+ let arr_type = arr.data_type();
+ match arr_type {
+ DataType::List(_) | DataType::FixedSizeList(_, _) => {
+ let list_array = as_list_array(&arr)?;
+ for (arr, &delimiter) in list_array.iter().zip(delimiters.iter()) {
Review Comment:
Like other function that cast with `as_generic_list_array`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
