Jefffrey commented on code in PR #8753:
URL: https://github.com/apache/arrow-datafusion/pull/8753#discussion_r1442454204
##########
datafusion-cli/src/exec.rs:
##########
@@ -278,6 +279,9 @@ async fn create_external_table(
let builder = get_gcs_object_store_builder(url, cmd)?;
Arc::new(builder.build()?) as Arc<dyn ObjectStore>
}
+ "http" | "https" => {
+
Arc::new(HttpBuilder::new().with_url(url.origin().ascii_serialization()).build()?)
as Arc<dyn ObjectStore>
+ }
Review Comment:
```suggestion
"http" | "https" => {
let builder =
HttpBuilder::new().with_url(url.origin().ascii_serialization());
Arc::new(builder.build()?) as Arc<dyn ObjectStore>
}
```
small nit, just to make it easier on the eyes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
