domoritz commented on code in PR #39457:
URL: https://github.com/apache/arrow/pull/39457#discussion_r1442926561
##########
js/src/data.ts:
##########
@@ -374,6 +375,13 @@ class MakeDataVisitor extends Visitor {
const { ['length']: length = valueOffsets.length - 1, ['nullCount']:
nullCount = props['nullBitmap'] ? -1 : 0 } = props;
return new Data(type, offset, length, nullCount, [valueOffsets,
undefined, nullBitmap], [child]);
}
+ public visitLargeList<T extends LargeList>(props: LargeListDataProps<T>) {
+ const { ['type']: type, ['offset']: offset = 0, ['child']: child } =
props;
+ const nullBitmap = toUint8Array(props['nullBitmap']);
+ const valueOffsets = toInt32Array(props['valueOffsets']);
Review Comment:
```suggestion
const valueOffsets = toBigInt64Array(props['valueOffsets']);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
