alamb commented on PR #8740: URL: https://github.com/apache/arrow-datafusion/pull/8740#issuecomment-1879197354
> Do we have any empirical numbers to support this, recomputing dictionaries is extremely expensive and I would have thought it would outweigh any other overheads? To be clear, the core rationale to revert this change is fix the functional regression (a query that used to run no longer does), as described in #8738 Once we have figure out how to avoid that functional regression with this change, we can also have a more reasonable discussion on performance. I will file a ticket to make some performance benchmarks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
