jayzhan211 commented on code in PR #7893:
URL: https://github.com/apache/arrow-datafusion/pull/7893#discussion_r1443647677
##########
datafusion/proto/tests/cases/roundtrip_logical_plan.rs:
##########
@@ -693,32 +694,6 @@ impl LogicalExtensionCodec for TopKExtensionCodec {
}
}
-#[test]
-fn scalar_values_error_serialization() {
- let should_fail_on_seralize: Vec<ScalarValue> = vec![
- // Should fail due to empty values
- ScalarValue::Struct(
- Some(vec![]),
Review Comment:
Move to `round_trip_scalar_values`, since it is able to serialized
```
ScalarValue::try_from(&DataType::Struct(Fields::from(vec![
Field::new("a", DataType::Int32, true),
Field::new("a", DataType::Boolean, false),
])))
.unwrap(),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
