Jefffrey commented on code in PR #8728:
URL: https://github.com/apache/arrow-datafusion/pull/8728#discussion_r1443660259


##########
.github/workflows/rust.yml:
##########
@@ -310,11 +310,10 @@ jobs:
           cd datafusion-cli
           cargo test --lib --tests --bins --all-features
         env:
-          # do not produce debug symbols to keep memory usage down
-          # use higher optimization level to overcome Windows rust slowness 
for tpc-ds
-          # and speed builds: 
https://github.com/apache/arrow-datafusion/issues/8696
-          # Cargo profile docs 
https://doc.rust-lang.org/cargo/reference/profiles.html?profile-settings#profile-settings
-          RUSTFLAGS: "-C debuginfo=0 -C opt-level=1 -C 
target-feature=+crt-static -C incremental=false -C codegen-units=256"

Review Comment:
   Removing the other optimization flags as it caused compilation to take 27 min
   
   Without them, it takes 8 min



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to