jayzhan211 commented on code in PR #8594:
URL: https://github.com/apache/arrow-datafusion/pull/8594#discussion_r1443882644
##########
datafusion/expr/src/signature.rs:
##########
@@ -122,6 +122,9 @@ pub enum TypeSignature {
/// List dimension of the List/LargeList is equivalent to the number of
List.
/// List dimension of the non-list is 0.
ArrayAndElement,
+ /// Specialized Signature for ArrayConcat
+ /// Accept arbitrary arguments but they SHOULD be List/LargeList or Null,
and the list dimension MAY NOT be the same.
+ ArrayConcat,
Review Comment:
> ist dimension MAY NOT be the same.
I mean MAY or MAY NOT.
array concat is able to concat different dimension array in DF.
`select array_concat([1, null], [null]);` is the normal cases, dimensions
are both 1.
`select array_concat([1, null], null);` is also valid, it acts like
`array_append`, where dimensions are 1 and 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
