jonahgao commented on code in PR #8785:
URL: https://github.com/apache/arrow-datafusion/pull/8785#discussion_r1444651501
##########
datafusion/proto/proto/datafusion.proto:
##########
@@ -212,7 +212,7 @@ message CreateExternalTableNode {
bool if_not_exists = 7;
string delimiter = 8;
string definition = 9;
- string file_compression_type = 10;
+ CompressionTypeVariant file_compression_type = 10;
Review Comment:
I think we should avoid reusing tag numbers.
The reasons can be referenced here.
- [Don’t Re-use a Tag Number
](https://protobuf.dev/programming-guides/dos-donts/#reuse-number)
- [Don’t Change the Type of a
Field](https://protobuf.dev/programming-guides/dos-donts/#change-type)
I prefer to make changes like the following.
```proto
reserved 10; // was string file_compression_type
CompressionTypeVariant file_compression_type = 17;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
