alamb opened a new pull request, #8787:
URL: https://github.com/apache/arrow-datafusion/pull/8787

   ## Which issue does this PR close?
   
   Follow on to https://github.com/apache/arrow-datafusion/pull/8774 / 
https://github.com/apache/arrow-datafusion/issues/8735
   
   ## Rationale for this change
   
   The core issue in https://github.com/apache/arrow-datafusion/issues/8735 was 
that one Expr type was forgotten. @haohuaijin restored the extra `Expr` type ❤️ 
   
   However, I think there is still some danger than a new Expr type would be 
added and forgotten to be added to this area. Thus I propose using the standard 
`TreeVisitor` to do the recursion
   
   ## What changes are included in this PR?
   Use `inspect_expr_pre` instead of manual recursion
   
   ## Are these changes tested?
   Covered by existing tests
   
   ## Are there any user-facing changes?
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to