AlenkaF commented on code in PR #39505:
URL: https://github.com/apache/arrow/pull/39505#discussion_r1445224285
##########
docs/source/conf.py:
##########
@@ -201,7 +201,12 @@
# General information about the project.
project = u'Apache Arrow'
-copyright = f'2016-{datetime.datetime.now().year} Apache Software Foundation'
+copyright = (
+ f"2016-{datetime.datetime.now().year} Apache Software Foundation.\n"
+ "Apache Arrow, Arrow, Apache, the Apache feather logo, and the Apache
Arrow "
+ "project logo are either registered trademarks or trademarks of The Apache
"
+ "Software Foundation in the United States and other countries."
Review Comment:
```suggestion
"Software Foundation in the United States and other countries"
```
It seems there is already a dot printed by default.
##########
docs/source/conf.py:
##########
@@ -201,7 +201,12 @@
# General information about the project.
project = u'Apache Arrow'
-copyright = f'2016-{datetime.datetime.now().year} Apache Software Foundation'
+copyright = (
+ f"2016-{datetime.datetime.now().year} Apache Software Foundation.\n"
Review Comment:
`\n` doesn't add a newline. We could try multiline copyright text with comma
separated items:
https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-copyright
like:
```
copyright = (
f"2016-{datetime.datetime.now().year} Apache Software Foundation.",
"Apache Arrow, Arrow, Apache, the Apache feather logo, and the Apache
Arrow project logo are either registered",
"trademarks or trademarks of The Apache Software Foundation in the
United States and other countries"
)
```
but would need to use newer version of Sphinx
([7.0.1](https://www.sphinx-doc.org/en/master/changes.html#release-7-1-0-released-jul-24-2023)).
I think we should unpin Sphinx anyways.
Breaking the copyright text into multiple lines would also make it smaller
in width and so the text on the right (PyData SphinxTheme text) could be kept
all in one line. See http://crossbow.voltrondata.com/pr_docs/39505/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
