lidavidm commented on code in PR #37723:
URL: https://github.com/apache/arrow/pull/37723#discussion_r1445288914
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/BaseAllocator.java:
##########
@@ -959,7 +1008,7 @@ private ArrowBuf allocate(int nBytes) {
final ArrowBuf arrowBuf =
BaseAllocator.this.bufferWithoutReservation(nBytes, null);
listener.onAllocation(nBytes);
- if (DEBUG) {
+ if (DEBUG && historicalLog != null) {
Review Comment:
Like the other checks above, we only need to check historicalLog, not DEBUG,
right?
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/BaseAllocator.java:
##########
@@ -982,7 +1031,7 @@ private void releaseReservation(int nBytes) {
releaseBytes(nBytes);
- if (DEBUG) {
+ if (DEBUG && historicalLog != null) {
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
