Jefffrey commented on code in PR #8792:
URL: https://github.com/apache/arrow-datafusion/pull/8792#discussion_r1445295344
##########
datafusion/common/src/error.rs:
##########
@@ -47,56 +47,82 @@ pub type GenericError = Box<dyn Error + Send + Sync>;
#[derive(Debug)]
pub enum DataFusionError {
/// Error returned by arrow.
+ ///
/// 2nd argument is for optional backtrace
ArrowError(ArrowError, Option<String>),
- /// Wraps an error from the Parquet crate
+ /// Error when reading Parquet data.
#[cfg(feature = "parquet")]
ParquetError(ParquetError),
- /// Wraps an error from the Avro crate
+ /// Error when reading Avro data.
#[cfg(feature = "avro")]
AvroError(AvroError),
- /// Wraps an error from the object_store crate
+ /// Error when reading from an object_store (e.g. S3 or LocalFile)
#[cfg(feature = "object_store")]
ObjectStore(object_store::Error),
- /// Error associated to I/O operations and associated traits.
+ /// Error when an I/O operation fails
IoError(io::Error),
- /// Error returned when SQL is syntactically incorrect.
+ /// Error when SQL is syntactically incorrect.
+ ///
/// 2nd argument is for optional backtrace
SQL(ParserError, Option<String>),
- /// Error returned on a branch that we know it is possible
- /// but to which we still have no implementation for.
- /// Often, these errors are tracked in our issue tracker.
+ /// Error when a features is not yet implemented.
Review Comment:
```suggestion
/// Error when a feature is not yet implemented.
```
Typo
##########
datafusion/common/src/error.rs:
##########
@@ -47,56 +47,82 @@ pub type GenericError = Box<dyn Error + Send + Sync>;
#[derive(Debug)]
pub enum DataFusionError {
/// Error returned by arrow.
+ ///
/// 2nd argument is for optional backtrace
ArrowError(ArrowError, Option<String>),
- /// Wraps an error from the Parquet crate
+ /// Error when reading Parquet data.
Review Comment:
Is this only for when reading parquet, or also when writing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
