vibhatha commented on issue #39330: URL: https://github.com/apache/arrow/issues/39330#issuecomment-1882093268
@lidavidm I am working on fixing the warnings, and there is a warning for an unused variable `context`, https://github.com/apache/arrow/blob/main/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java#L479-L628 ```bash [WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[604,35] [UnusedVariable] The parameter 'context' is never read. (see https://errorprone.info/bugpattern/UnusedVariable) Did you mean 'error(reader, writer);'? [WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[600,36] [UnusedVariable] The parameter 'context' is never read. (see https://errorprone.info/bugpattern/UnusedVariable) Did you mean 'cancel(reader, writer);'? [WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[525,34] [UnusedVariable] The parameter 'context' is never read. (see https://errorprone.info/bugpattern/UnusedVariable) Did you mean 'echo(reader, writer);'? [WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[513,42] [UnusedVariable] The parameter 'context' is never read. (see https://errorprone.info/bugpattern/UnusedVariable) Did you mean 'metadataOnly(reader, writer);'? [WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[558,39] [UnusedVariable] The parameter 'context' is never read. (see https://errorprone.info/bugpattern/UnusedVariable) Did you mean 'transform(reader, writer);'? [WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[479,57] [UnusedVariable] The parameter 'reader' is never read. (see https://errorprone.info/bugpattern/UnusedVariable) Did you mean 'doGet(context, writer);'? [WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[600,58] [UnusedVariable] The parameter 'reader' is never read. (see https://errorprone.info/bugpattern/UnusedVariable) Did you mean 'cancel(context, writer);'? [WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[496,35] [UnusedVariable] The parameter 'context' is never read. (see https://errorprone.info/bugpattern/UnusedVariable) Did you mean 'doPut(reader, writer);'? [WARNING] /Users/vibhatha/github/fork/arrow/java/flight/flight-core/src/test/java/org/apache/arrow/flight/TestDoExchange.java:[479,35] [UnusedVariable] The parameter 'context' is never read. (see https://errorprone.info/bugpattern/UnusedVariable) Did you mean 'doGet(reader, writer);'? ``` Should we ignore this warning for now? I assume there should be a solid reason for introducing context to those functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
