kou commented on code in PR #39522:
URL: https://github.com/apache/arrow/pull/39522#discussion_r1445573215
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -2040,10 +2040,17 @@ macro(build_jemalloc)
# Enable jemalloc debug checks when Arrow itself has debugging enabled
list(APPEND JEMALLOC_CONFIGURE_COMMAND "--enable-debug")
endif()
+
set(JEMALLOC_BUILD_COMMAND ${MAKE} ${MAKE_BUILD_ARGS})
+ # Paralleism for Make fails with CMake > 3.28 see #39517
+ if(${CMAKE_GENERATOR} MATCHES "Makefiles")
+ list(APPEND JEMALLOC_BUILD_COMMAND "-j1")
Review Comment:
It's not a strong opinion but I think that we should choose safer option
(disable `make`'s parallel build for all dependencies) here.
Because we have a workaround (use `-GNinja`) for the parallel build problem.
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -446,8 +446,8 @@ endmacro()
file(STRINGS "${THIRDPARTY_DIR}/versions.txt" TOOLCHAIN_VERSIONS_TXT)
foreach(_VERSION_ENTRY ${TOOLCHAIN_VERSIONS_TXT})
# Exclude comments
- if(NOT ((_VERSION_ENTRY MATCHES "^[^#][A-Za-z0-9-_]+_VERSION=")
- OR (_VERSION_ENTRY MATCHES "^[^#][A-Za-z0-9-_]+_CHECKSUM=")))
+ if(NOT ((_VERSION_ENTRY MATCHES "^[^ #][A-Za-z0-9-_]+_VERSION=")
+ OR (_VERSION_ENTRY MATCHES "^[^ #][A-Za-z0-9-_]+_CHECKSUM=")))
Review Comment:
Wow. What CMake linter did you use? And what the error message from the
CMake linter?
It seems that this diff changes matched pattern. (I think that it doesn't
have any problem in our use case.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
