AlenkaF commented on code in PR #39380:
URL: https://github.com/apache/arrow/pull/39380#discussion_r1445819815
##########
python/pyarrow/src/arrow/python/common.cc:
##########
@@ -131,6 +138,34 @@ class PythonErrorDetail : public StatusDetail {
}
protected:
+ Result<std::string> FormatImpl() const {
+ PyAcquireGIL lock;
+
+ // Use traceback.format_exception()
+ OwnedRef traceback_module;
+ RETURN_NOT_OK(internal::ImportModule("traceback", &traceback_module));
Review Comment:
It seems we are already retrieving the error indicator and saving the
traceback in `PythonErrorDetail` class, but can be reading the code wrong.
Would it be possible to use `exc_traceback_.obj()` similar to
`exc_type_.obj()` so there would be no need to use the traceback module?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
