huberylee commented on code in PR #39393:
URL: https://github.com/apache/arrow/pull/39393#discussion_r1446057172
##########
cpp/src/parquet/arrow/reader_internal.h:
##########
@@ -68,15 +72,34 @@ class FileColumnIterator {
schema_(reader->metadata()->schema()),
row_groups_(row_groups.begin(), row_groups.end()) {}
+ explicit FileColumnIterator(int column_index, ParquetFileReader* reader,
+ std::vector<int> row_groups, RowRangesOpt
row_ranges)
Review Comment:
> Consider to combine row_groups and row_ranges.
Split row_groups and row_ranges into two different args is meaningful, for
some row groups only hit some rows, and some row groups hit all rows in row
group.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
