yyy1000 commented on code in PR #8780:
URL: https://github.com/apache/arrow-datafusion/pull/8780#discussion_r1446654052
##########
datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs:
##########
@@ -1594,6 +1641,20 @@ mod tests {
// --- Simplifier tests -----
// ------------------------------
+ #[test]
+ fn test_simplify_canonicalize() {
+ {
+ let expr = lit(1).lt(col("c2")).and(col("c2").gt(lit(1)));
+ let expected = col("c2").gt(lit(1));
+ assert_eq!(simplify(expr), expected);
+ }
+ {
+ let expr = col("c1").lt(col("c2")).and(col("c2").gt(col("c1")));
+ let expected = col("c2").gt(col("c1"));
+ assert_eq!(simplify(expr), expected);
+ }
+ }
Review Comment:
Correct, in the test case, for `A < 5 AND A >= 5 --> same`, it will make no
change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
