jorisvandenbossche commented on issue #39489: URL: https://github.com/apache/arrow/issues/39489#issuecomment-1884403856
Actually, my comment above was wrong: > when converting a TimestampLogicalType to an Arrow timestamp type, we do ignore the `isAdjustedToUtc` flag if the logical type has been annotated to come from a converted type. So then changing `isAdjustedToUtc` in those cases shouldn't actually impact any behaviour in the Arrow API layer of the Parquet library? This is exactly what your PR changed, i.e. it's the conversion from a Parquet type to Arrow type (`MakeArrowTimestamp`) that now _no longer_ ignores `isAdjustedToUtc` for converted types. So of course this does change behaviour, also for the Arrow APIs. And so the consequence of this is that reading an older file written by Arrow, will now be read differently (and this was a compatibility that was explicitly added in https://github.com/apache/arrow/pull/4856). It's maybe OK to change this behaviour, so we give up faithful roundtrip for those older files written by Arrow (in the end, it are old files), in favor of better compatibility with the Parquet spec and other producers, but we need to be explicit about that this is actually a behaviour change for users. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
