davidhcoe commented on code in PR #1356:
URL: https://github.com/apache/arrow-adbc/pull/1356#discussion_r1447519670
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -683,8 +691,40 @@ private XdbcDataType ToXdbcDataType(string type)
return XdbcDataType.XdbcDataType_XDBC_VARBINARY;
case "NUMERIC" or "DECIMAL" or "BIGNUMERIC" or "BIGDECIMAL":
return XdbcDataType.XdbcDataType_XDBC_NUMERIC;
-
default:
+
+ int decimalMaxScale = 28;
Review Comment:
Yes, that is the reason. In SqlDecimal.ToDecimal() if scale > 28 then an
OverthrowException is thrown. This is the XDBC metadata that is matching the
SqlDecimal type that would come back for the value. I added comments in line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
