alamb commented on code in PR #8810: URL: https://github.com/apache/arrow-datafusion/pull/8810#discussion_r1447852934
########## pre-commit.sh: ########## @@ -60,7 +60,7 @@ echo -e "$(GREEN INFO): cargo clippy ..." # Cargo clippy always return exit code 0, and `tee` doesn't work. # So let's just run cargo clippy. -cargo clippy +cargo clippy --all-targets --workspace --features avro,pyarrow -- -D warnings Review Comment: I wonder if it would be better to run the same exact script CI does, namely https://github.com/apache/arrow-datafusion/blob/main/ci/scripts/rust_clippy.sh (the CI runs it here https://github.com/apache/arrow-datafusion/blob/e86253919983ffe89d74ec1310f5f080482adcff/.github/workflows/rust.yml#L475C14-L475C39) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
