alamb commented on PR #8818: URL: https://github.com/apache/arrow-datafusion/pull/8818#issuecomment-1885716070
> @alamb Hello,excuse me > I found that there is a test about the now function in timestamp.slt. I don’t know if I should add it. > And if I add the select now test, the result may be fixed, but the result of now is changing all the time, which may have an impact on the project itself. Hi @caicancai -- if there are tests that can't be ported to sqllogictest (for example, that now() doesn't change across session statements) can you please put a comment on them saying something like "can't write this in sqllogictest, so use a rust test" and just leave them in timestamp.rs? Thank you 🙏 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
